This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v7 01/10] Move utility functions to common/


> gdb/ChangeLog
> 2014-02-26  Aleksandar Ristovski  <aristovski@qnx.com
> 	    Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Move utility functions to common/.
> 	* cli/cli-utils.c (skip_spaces, skip_spaces_const, skip_to_space_const):
> 	Move defs to common/common-utils.c.
> 	* cli/cli-utils.h (skip_spaces, skip_spaces_const, skip_to_space)
> 	(skip_to_space_const): Move decls to common/common-utils.h.
> 	* common/common-defs.h: Move include of common-types.h before
> 	common-utils.h.
> 	* common/common-utils.c: Include host-defs.h and ctype.h.
> 	(HIGH_BYTE_POSN, is_digit_in_base, digit_to_int, strtoulst): Move
> 	from utils.c.
> 	(skip_spaces, skip_spaces_const, skip_to_space_const): Move from
> 	cli/cli-utils.c.
> 	* common/common-utils.h (strtoulst): Move decl from utils.h.
> 	(skip_spaces, skip_spaces_const, skip_to_space, skip_to_space_const):
> 	Move from cli/cli-utils.h.
> 	* common/host-defs.h: Include limits.h.
> 	(TARGET_CHAR_BIT, HOST_CHAR_BIT): Moved from defs.h.
> 	(skip_spaces, skip_spaces_const): Move decls from cli/cli-utils.h.
> 	* defs.h (TARGET_CHAR_BIT, HOST_CHAR_BIT): Move to
> 	common/common-utils.h.
> 	* utils.c (HIGH_BYTE_POSN, is_digit_in_base, digit_to_int)
> 	(strtoulst): Move to common/common-utils.c.
> 	* utils.h (strtoulst): Moved decl to common/common-utils.h.

This one looks pretty straightfoward and useful, so OK.

I *think* from reading through the patch that some of the functions
being moved don't have documentation. This is not for this patch,
but if you wouldn't mind, would you use this opportunity to  add
that documentation as a followup patch? If you don't have the time,
then no problem, but do let me know so I can go in and do that.

Thanks,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]