This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v8 09/10] Validate symbol file using build-id


FWIW, looks good to me.

Minor thing: it seems you did not put space before the comment block, but
in the practice most of such blocks are separated by an empty line from
the previous.
Example: 
...
}
+/* Boolean for command 'set solib-build-id-force'.  */
...


Thanks,

Aleksandar Ristovski
QNX Software Systems


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]