This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb: microblaze: delete useless stubs


On 06/21/2015 09:56 PM, Mike Frysinger wrote:
On 21 Jun 2015 12:36, Michael Eager wrote:
On 06/21/2015 11:13 AM, Mike Frysinger wrote:
These don't accomplish anything the common core doesn't already, so
punt them as they purely waste code.

2015-06-21  Mike Frysinger  <vapier@gentoo.org>

	* microblaze-tdep.c (microblaze_push_dummy_code): Delete.
	(microblaze_push_dummy_call): Likewise.
	(microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
	and set_gdbarch_push_dummy_call.

Does the common code issue an error if someone tries
to call a target function?

yes

gdb/infcall.c:
struct value *
call_function_by_hand_dummy (struct value *function,
...
   if (!gdbarch_push_dummy_call_p (gdbarch))
     error (_("This target does not support function calls."));

$ ./gdb ...
(gdb) p foo(1)
This target does not support function calls.
-mike

Go ahead and commit.


--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]