This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v8 09/10] Validate symbol file using build-id
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Aleksandar Ristovski <ARistovski at qnx dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 22 Jun 2015 22:37:00 +0200
- Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192655 dot 18346 dot 17075 dot stgit at host1 dot jankratochvil dot net> <20150621101644 dot GA12733 at host1 dot jankratochvil dot net> <D1AD7D6A dot D079%aristovski at qnx dot com>
On Mon, 22 Jun 2015 14:55:14 +0200, Aleksandar Ristovski wrote:
> Minor thing: it seems you did not put space before the comment block, but
> in the practice most of such blocks are separated by an empty line from
> the previous.
> Example:
> ...
> }
> +/* Boolean for command 'set solib-build-id-force'. */
> ...
I guess it is some mail reading problem. The patch is:
1: }\n
2: \n
3:+/* Boolean for command 'set solib-build-id-force'. */\n
4:+static int solib_build_id_force = 0;\n
5:+\n
6:+/* Implement 'show solib-build-id-force'. */\n
7:+\n
8:+static void\n
I believe you ask about the empty line 2 - but that one is there.
The missing empty line between lines 3 and 4 and the present empty line 7 are
conforming to:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
Jan