This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 23 Jun 2015 10:28:25 -0400
- Subject: Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
- Authentication-results: sourceware.org; auth=none
- References: <1432293831-23599-1-git-send-email-patrick at parcs dot ath dot cx> <1432293831-23599-2-git-send-email-patrick at parcs dot ath dot cx> <86zj3qr3at dot fsf at gmail dot com>
On Tue, Jun 23, 2015 at 8:56 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Patrick Palka <patrick@parcs.ath.cx> writes:
>
> Hi Patrick,
>
>> +# A huge number (hopefully larger than INT_MAX)
>> +test_histsize_history_setting "99999999999999999999999999999999999"
>> "unlimited"
>
> This test fails on some targets (32-bit?) as shown in buildbot,
> https://www.sourceware.org/ml/gdb-testers/2015-q2/msg06883.html
>
> (gdb) show history size
> The size of the command history is 2147483647.
> (gdb) FAIL: gdb.base/gdbhistsize-history.exp: histsize=99999999999999999999999999999999999: show history size
>
> --
> Yao (éå)
Thanks for the heads up. I failed to account for targets where
INT_MAX == LONG_MAX. I have a patch to send.