This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2] compile: Fix crash on cv-qualified self-reference
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org, Phil Muldoon <pmuldoon at redhat dot com>
- Date: Wed, 01 Jul 2015 17:16:43 +0100
- Subject: Re: [patchv2] compile: Fix crash on cv-qualified self-reference
- Authentication-results: sourceware.org; auth=none
- References: <20150516132555 dot GB17266 at host1 dot jankratochvil dot net> <86lhf0p1hf dot fsf at gmail dot com> <20150701132406 dot GA13975 at host1 dot jankratochvil dot net> <5593F10D dot 4020903 at redhat dot com> <20150701141003 dot GA19545 at host1 dot jankratochvil dot net> <55940059 dot 30603 at redhat dot com> <20150701151202 dot GA21275 at host1 dot jankratochvil dot net> <55940636 dot 9000604 at redhat dot com> <20150701152919 dot GA23462 at host1 dot jankratochvil dot net> <559408AE dot 10904 at redhat dot com> <20150701160713 dot GA26015 at host1 dot jankratochvil dot net>
On 07/01/2015 05:07 PM, Jan Kratochvil wrote:
> On Wed, 01 Jul 2015 17:35:10 +0200, Pedro Alves wrote:
>> On 07/01/2015 04:29 PM, Jan Kratochvil wrote:
>>> From 1 mandatory macro 3 mandatory macros and breaking all 3rd party patches.
>>> When GDB codebase finally gets compiled by clang++ I agree it will be an
>>> improvement.
>>
>> Seriously, that's a depressing and demotivating comment.
>> You want it done, but you also want it not done.
>
> Do you mean the first sentence or the second sentence?
>
The whole of it. If we had converted to pure C++ in one go, you'd have
had to revolve the same conflicts too. And the conflicts resulting from
the final conversion from TRY/CATCH to native try/catch will be super
trivial to resolve, as that won't move code around.
> I agree the first sentence is demotivating but I feel the same spending a lot
> of time rebasing patches again and again on changes that end up half-way or
> that are questionable whether they really cleaned up the code. Although
> specifically for this TRY_CATCH->TRY case I had fortunately only two such
> cases.
And still, you complain.
This is truly pointless. Sorry, I'm out of here.
Thanks,
Pedro Alves