This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Several regressions and we branch soon.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: Doug Evans <dje at google dot com>, Keith Seitz <keiths at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 02 Jul 2015 16:34:10 +0100
- Subject: Re: Several regressions and we branch soon.
- Authentication-results: sourceware.org; auth=none
- References: <CADPb22SYnN52pqR+1UtR_Vr-1Yxzmx=OyMgnCD-OMcCL1GwAYg at mail dot gmail dot com> <CA+C-WL_uZdNj29-6u4MnqH-8zQt9Q20fzUb6b9nWHKJPCstY9A at mail dot gmail dot com> <CADPb22Rg2FySdxWo9VKb5WApPh-wdf946po9UXX-+kQ99bULug at mail dot gmail dot com> <5589BECB dot 7090200 at redhat dot com> <CADPb22RbcoyxPwwTTQCjSTdexN-D-gfWPd6doF2KbcMm074XyA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 20 dot 8 dot 1506231742590 dot 4322 at idea>
Hi Patrick,
After discussing with Walfred Tedeschi on intel mpx, I think command
"show mpx bound" still needs an input argument, otherwise, GDB
will display many bound table entries, which is less useful to
users.
I don't want to rename the command to "show-mpx-bound", because GDB
doesn't have any other "show-*" commands. So looks your fix is the
best one I can think of.
On 23/06/15 22:45, Patrick Palka wrote:
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 42d0346..d11efa1 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -8777,11 +8777,17 @@ i386_mpx_info_bounds (char *args, int from_tty)
struct type *data_ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
if (!i386_mpx_enabled ())
- error (_("Intel(R) Memory Protection Extensions not\
- supported on this target."));
+ {
+ printf_unfiltered (_("Intel(R) Memory Protection Extensions not "
+ "supported on this target.\n"));
The indentation looks wrong to me.
+ return;
+ }
Could you add the changelog entry in your patch, and post it again?
Then, it can be reviewed properly.
--
Yao (éå)