This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't throw an error in "show mpx bound" implementation
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: gdb-patches at sourceware dot org, qiyaoltc at gmail dot com
- Date: Mon, 06 Jul 2015 10:31:44 +0100
- Subject: Re: [PATCH] Don't throw an error in "show mpx bound" implementation
- Authentication-results: sourceware.org; auth=none
- References: <559559F2 dot 90700 at gmail dot com> <1435853930-32119-1-git-send-email-patrick at parcs dot ath dot cx>
Patrick Palka <patrick@parcs.ath.cx> writes:
> "show" functions should not throw an exception in part because it causes
> the output of the commands "info set" and "show" to get truncated.
>
> This fixes the following fails:
>
> FAIL: gdb.base/default.exp: info set
> FAIL: gdb.base/default.exp: show
>
> gdb/ChangeLog:
>
> * i386-tdep.c (i386_mpx_info_bounds): Don't call error, instead
> use printf_unfiltered.
> (set_mpx_cmd): Add missing trailing space to command string
> literal.
> (_initialize_i386_tdep): Give the "mpx" prefix command its
> correct name.
It looks good to me. Thanks.
--
Yao (éå)