This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7] Split c_val_print
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 09 Jul 2015 11:53:37 +0100
- Subject: Re: [PATCH 0/7] Split c_val_print
- Authentication-results: sourceware.org; auth=none
- References: <1436389629-18754-1-git-send-email-simon dot marchi at ericsson dot com>
On 07/08/2015 10:07 PM, Simon Marchi wrote:
> I think that c_val_print deserves to be split up in smaller, more
> manageable chunks. This series does that, by simply factoring out each
> case of the big switch. In some cases, a bit of modifications were
> necessary where fallthrough between cases or goto were used, but
> otherwise the code stays the same.
Nice! A couple issues need to be fixed and this is good to go.
- The intro comment to print_unpacked_pointer in patch 2
uses the wrong format (leading * in each line?).
- For convention, make sure there's a line break after
each variable declaration.
Fix these and push.
Thanks,
Pedro Alves