This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove CHECK_TYPEDEF, use check_typedef instead


On Sat, Jul 11, 2015 at 1:32 PM, Pedro Alves <palves@redhat.com> wrote:
> On 07/11/2015 02:18 PM, Doug Evans wrote:
>
>> I'm not advocating for a really_long_function_name_that_mentions_all_actions,
>> just pointing out that the current situation is lacking.
>> Something like "resolve_type" might work for me,
>> but I haven't put too much time into it.
>
> Agreed with all points.
>
> If we set aside renaming (as it seems like an orthogonal issue, and I'm
> guilty for bringing it up), you in favor or against removing
> CHECK_TYPEDEF, as in Simon's patch?
>
> Myself, I've been acquainted with the CHECK_TYPEDEF macro for so long, that
> it no longer confuses me, but Simon quickly convinced me that as is, two ways
> of doing the exact same isn't much useful and confuses newcomers.  So I'm
> leaning on taking his patch.

I'm certainly ok with removing CHECK_TYPEDEF, it's a good step forward IMO.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]