This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 09/10] Validate symbol file using build-id
- From: Pedro Alves <palves at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: dje at google dot com, gdb-patches at sourceware dot org, ARistovski at qnx dot com
- Date: Mon, 13 Jul 2015 11:34:33 +0100
- Subject: Re: [PATCH v9 09/10] Validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192655 dot 18346 dot 17075 dot stgit at host1 dot jankratochvil dot net> <20150621101644 dot GA12733 at host1 dot jankratochvil dot net> <CADPb22TH5nfFSkCzW9cCiHuoJFAG+P5z=qZawgwGUgYQ5kfd5Q at mail dot gmail dot com> <20150623204702 dot GA2156 at host1 dot jankratochvil dot net> <559D3749 dot 9010200 at redhat dot com> <20150712190921 dot GA8682 at host1 dot jankratochvil dot net> <20150712192911 dot GB12553 at host1 dot jankratochvil dot net> <83vbdp8846 dot fsf at gnu dot org>
On 07/12/2015 08:54 PM, Eli Zaretskii wrote:
>> Date: Sun, 12 Jul 2015 21:29:11 +0200
>> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>> Cc: Doug Evans <dje@google.com>, gdb-patches <gdb-patches@sourceware.org>,
>> Aleksandar Ristovski <ARistovski@qnx.com>,
>> Eli Zaretskii <eliz@gnu.org>
>>
>>>> "build-id-force" sound odd to me. The latter sounds OK,
>>>> as would "set build-id-validation on/off/...".
>>>
>>> OK, I will change it to "set build-id-validation on/off/...".
>>
>> It required some language changes as it reversed its on<->off meaning,
>> therefore Ccing Eli.
>
> It's OK, although I wonder whether solib-validate-build-id is perhaps
> a better name.
As the plan is for the feature to apply to the main executable too,
it's better that "solib" isn't part of the setting name. I agree
that "validate-build-id" sounds better than "build-id-validation".
Thanks,
Pedro Alves