This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Use debug_printf to print debug message
- From: Gary Benson <gbenson at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Jul 2015 15:02:21 +0100
- Subject: Re: [PATCH 2/4] Use debug_printf to print debug message
- Authentication-results: sourceware.org; auth=none
- References: <1436282578-8070-1-git-send-email-yao dot qi at linaro dot org> <1436282578-8070-3-git-send-email-yao dot qi at linaro dot org>
Yao Qi wrote:
> Some functions in aarch64-linux-nat.c and linux-aarch64-low.c looks
> the same except for the code printing debug message. In GDB, we use
> fprintf_unfiltered (gdb_stdlog, ...) while in GDBserver, we use
> fprintf (stderr, ...). This patch is to change them to use
> debug_printf so that these functions are the same, and I can move
> them to a common place in the following patch.
...
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 94093fc..869edda 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -426,30 +426,28 @@ aarch64_show_debug_reg_state (struct aarch64_debug_reg_state *state,
> {
> int i;
>
> - fprintf_unfiltered (gdb_stdlog, "%s", func);
> + debug_printf ( "%s", func);
Just this one problem, an extra whitespace after the paren.
Otherwise looks good.
Thanks,
Gary
--
http://gbenson.net/