This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [AArch64] Mark single precision pseudo registers unavailable if invalid
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pierre Langlois <pierre dot langlois at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 15 Jul 2015 15:41:03 +0100
- Subject: Re: [PATCH] [AArch64] Mark single precision pseudo registers unavailable if invalid
- Authentication-results: sourceware.org; auth=none
- References: <1436957554-1403-1-git-send-email-pierre dot langlois at arm dot com> <86mvyxjzah dot fsf at gmail dot com>
On 15/07/15 15:00, Yao Qi wrote:
... when I read your patch, I am wondering why does aarch64 implement
gdbarch method pseudo_register_read_value rather than
pseudo_register_read. If we implement the pseudo_register_read, the
caller will mark the value unavailable according to its return value.
pseudo_register_read_value was added to handle partially available
registers byhttps://sourceware.org/ml/gdb-patches/2011-07/msg00351.html
but I don't think of a case that some aarch64 register is partially
available. Maybe, another fix to this problem is to implement
pseudo_register_read instead of pseudo_register_read_value.
To be clear, your patch can be pushed in, as it is correct and fixes
fails in tests. We can discuss and implement pseudo_register_read
rather than pseudo_register_read_value for aarch64 later in the
follow-up patch.
--
Yao (éå)