This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [AArch64] Mark single precision pseudo registers unavailable if invalid


On 15/07/15 15:00, Yao Qi wrote:
... when I read your patch, I am wondering why does aarch64 implement
gdbarch method pseudo_register_read_value rather than
pseudo_register_read.  If we implement the pseudo_register_read, the
caller will mark the value unavailable according to its return value.
pseudo_register_read_value was added to handle partially available
registers byhttps://sourceware.org/ml/gdb-patches/2011-07/msg00351.html
but I don't think of a case that some aarch64 register is partially
available.  Maybe, another fix to this problem is to implement
pseudo_register_read instead of pseudo_register_read_value.

To be clear, your patch can be pushed in, as it is correct and fixes
fails in tests.  We can discuss and implement pseudo_register_read
rather than pseudo_register_read_value for aarch64 later in the
follow-up patch.

--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]