This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v10 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org, Aleksandar Ristovski <ARistovski at qnx dot com>
- Date: Thu, 16 Jul 2015 10:32:14 +0200
- Subject: Re: [PATCH v10 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch]
- Authentication-results: sourceware.org; auth=none
- References: <20150607200422 dot 8918 dot 48900 dot stgit at host1 dot jankratochvil dot net> <20150607200454 dot 8918 dot 52868 dot stgit at host1 dot jankratochvil dot net> <20150608083733 dot GA5405 at blade dot nx> <20150715212028 dot GA22133 at host1 dot jankratochvil dot net> <20150716081412 dot GA4954 at blade dot nx>
On Thu, 16 Jul 2015 10:14:12 +0200, Gary Benson wrote:
> I don't fully understand the tdep/non-tdep split very well.
I understand that *-tdep.c is all of the support that makes sense for all the
arch support that can be done cross-arch for loading/examining files plus all
the arch support usable with remote gdbserver (cross-arch in general, with
gdbserver it can be also native-arch but that does not matter).
linux-maps.[ch] provides linux_find_memory_regions_full() which is used in
linux-tdep.c and in gdbserver but for mostly unrelated purposes, so it is
rather just a code reuse and it is not architecturally the same functionality
called from both linux-nat+gdbserver just because linux-nat hasn't been
dropped yet.
linux-maps.[ch] also exports its read_mapping() to linux-tdep.c which is again
only arbitrary code reuse from two unrelated places of code.
Jan