Re: [PATCH] Add proper handling for non-local references in nested functions

[Kevin Buettner <kevinb at redhat dot com>]

On Thu, 23 Jul 2015 18:14:12 +0200
Pierre-Marie de Rodat <derodat@adacore.com> wrote:

> On 07/23/2015 03:44 PM, Kevin Buettner wrote:
>
> > I'll test your new patch today.  I've encountered a GDB bug related to
> > examining variables with within a nested function.  I'm hoping that
> > your patch will fix it...
> 
> I am as well: keep me updated! ;-)

I ran into another issue, both yesterday and today, when attempting to
apply your patch.  Apparently, it adds some test cases,
gdb.base/nested-subp1.c, gdb.base/nested-subp1.exp, etc. which already
exist.  As can be seen in the log below, I told patch to not assume -R
as well as to not apply the patch.  I'm using sources, current as of
yesterday, upon which I first applied your other patch,
0001-Replace-the-block_found-global-with-explicit-data-fl.patch.

Here's the log showing the issue I ran into:

[kev@pinnacle gdb]$ patch -p2 </tmp/0001-DWARF-handle-non-local-references-in-nested-function.patch 
patching file ada-lang.c
patching file block.c
patching file block.h
patching file buildsym.c
patching file buildsym.h
patching file c-exp.y
patching file coffread.c
patching file compile/compile-c-symbols.c
patching file compile/compile-loc2c.c
patching file d-exp.y
patching file dbxread.c
patching file dwarf2loc.c
patching file dwarf2loc.h
patching file dwarf2read.c
patching file f-exp.y
patching file findvar.c
patching file gdbtypes.c
patching file go-exp.y
patching file infcmd.c
patching file infrun.c
patching file jv-exp.y
patching file language.h
patching file m2-exp.y
patching file objfiles.c
patching file objfiles.h
patching file p-exp.y
patching file printcmd.c
patching file python/py-finishbreakpoint.c
patching file python/py-frame.c
patching file python/py-framefilter.c
patching file python/py-symbol.c
patching file stack.c
patching file symtab.h
The next patch would create the file testsuite/gdb.base/nested-subp1.c,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp1.exp,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp2.c,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp2.exp,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp3.c,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp3.exp,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
patching file valops.c
patching file value.h
patching file xcoffread.c