This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 01/14] Factor out print_unpacked_pointer from generic_val_print
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Thu, 23 Jul 2015 22:45:37 +0100
- Subject: Re: [PATCH 01/14] Factor out print_unpacked_pointer from generic_val_print
- Authentication-results: sourceware.org; auth=none
- References: <1436978863-15125-1-git-send-email-simon dot marchi at ericsson dot com> <1436978863-15125-2-git-send-email-simon dot marchi at ericsson dot com>
On 07/15/2015 05:47 PM, Simon Marchi wrote:
>
> diff --git a/gdb/valprint.c b/gdb/valprint.c
> index 52a386a..eee52c5 100644
> --- a/gdb/valprint.c
> +++ b/gdb/valprint.c
> @@ -359,6 +359,33 @@ val_print_invalid_address (struct ui_file *stream)
> fprintf_filtered (stream, _("<invalid address>"));
> }
>
> +/* Print a pointer based on the type of its target.
> +
> + Arguments to this functions are roughly the same as those in
> + generic_val_print. A difference is that ADDRESS is the address to print,
> + with embedded_offset already added. UNRESOLVED_ELTTYPE and ELTTYPE represent the pointed type,
> + respectively before and after check_typedef. */
Line too long. Comment seems stale -- there's no UNRESOLVED_ELTTYPE
parameter.
Otherwise looks good.
Thanks,
Pedro Alves