This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 00/14] Split generic_val_print in smaller parts
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Mon, 27 Jul 2015 14:14:50 -0400
- Subject: Re: [PATCH 00/14] Split generic_val_print in smaller parts
- Authentication-results: sourceware.org; auth=none
- References: <1436978863-15125-1-git-send-email-simon dot marchi at ericsson dot com> <55B16288 dot 5080300 at redhat dot com>
On 15-07-23 05:54 PM, Pedro Alves wrote:
> On 07/15/2015 05:47 PM, Simon Marchi wrote:
>
>> Simon Marchi (14):
>> Factor out print_unpacked_pointer from generic_val_print
>> Factor out array printing code from generic_val_print
>> Factor out pointer printing code from generic_val_print
>> Factor out memberptr printing code from generic_val_print
>> Factor out reference printing code from generic_val_print
>> Factor out enum printing code from generic_val_print
>> Factor out flags printing code from generic_val_print
>> Factor out function/method printing code from generic_val_print
>> Factor out bool printing code from generic_val_print
>> Factor out int printing code from generic_val_print
>> Factor out char printing code from generic_val_print
>> Factor out float printing code from generic_val_print
>> Factor out decfloat printing code from generic_val_print
>> Factor out complex printing code from generic_val_print
>
> I read the whole series. Patches that I didn't comment
> on looked OK to me as is. The one's I commented on,
> just fix them and push right ahead.
>
> Nice cleanup! Keep 'em coming. :-)
>
> Thanks,
> Pedro Alves
I did the fixes and pushed. I'll post the final versions of
the patches that were modified.
Thanks
Simon