This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules

From: Pierre-Marie de Rodat <derodat at adacore dot com>
To: Iain Buclaw <ibuclaw at gdcproject dot org>, GDB Patches <gdb-patches at sourceware dot org>, Doug Evans <xdje42 at gmail dot com>
Date: Tue, 4 Aug 2015 10:27:51 +0200
Subject: Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
Authentication-results: sourceware.org; auth=none
References: <CABOHX+diCq3hB1g66c7hhoCgfJ9A67EiSBd-E99edrWHskWKbQ at mail dot gmail dot com>

Hello,

On 08/03/2015 08:00 PM, Iain Buclaw wrote:

Rebased this against master, in particular to make it compatible with
the recent block_symbol additions.  I don't have a GCC-4.1 compiler at
hand, but I don't think I'm doing anything that may trigger build
warnings.  Pierre, maybe you want to confirm?

Well, I don't have easy access to one neither. ;-) I had a very quicklook at your patch and it seems that all usage of block_symbol variablesare dominated by at least one affectation (sym = lookup...), so I guessthe problem Ulrich and Steve noticed should not arise here.

... except maybe in one place: in find_symbol_in_baseclass, the returnedvalue is uninitialized if we don't enter the FOR loop (is that onlypossible in practice?). So what about providing {NULL, NULL} as anininialization value to "sym", there?


--
Pierre-Marie de Rodat

Follow-Ups:
- Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
  - From: Iain Buclaw

References:
- [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
  - From: Iain Buclaw

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]