This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.

From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Tue, 4 Aug 2015 10:18:48 -0400
Subject: Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.
Authentication-results: sourceware.org; auth=none
References: <1438353367-24936-1-git-send-email-antoine dot tremblay at ericsson dot com> <861tfje4qq dot fsf at gmail dot com>

On 08/04/2015 06:18 AM, Yao Qi wrote:

Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

Hi Antoine, I am lost in the description of your patch.

Without this patch, when doing a software single step, with for example
a conditional breakpoint, gdbserver would wrongly avance the pc of
breakpoint_len and skip an instruction.


GDBserver doesn't support software single step.  Does your patch fix
some bug in current GDBserver or in GDBserver with software single step
enabled?  If it is the latter, then, you need to include this patch
in your patch series supporting software single step in GDBserver,
rather than sending it separately.

It does support it for mips,sparc,nios2,cris,crisv32 if I do a grep fromreinsert_addr...


can_hardware_single_step will return false for these ones...

Unless I've missed something ?

Follow-Ups:
- Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.
  - From: Antoine Tremblay

References:
- Re: [PATCH] Fix instruction skipping when using software single step in gdbserver.
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]