This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Change type of struct complaints::series
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Wed, 5 Aug 2015 17:44:39 -0400
- Subject: [PATCH] Change type of struct complaints::series
- Authentication-results: sourceware.org; auth=none
Found while processing the C++ enum changes. It seems like series
should be of type enum complaint_series, instead of adding a cast.
If somebody could guide me a little bit, I think I could clean up the
comments around this. The comments on enum complaint_series and the
series field seem redundant and maybe out of date. Do the "case N" in
the comments refer to the enum values? If so they don't seem to match
the actual values.
gdb/ChangeLog:
* complaints.c (enum complaint_series): Add newlines.
(struct complaints) <series>: Change type to enum
complaint_series.
(symfile_complaint_hook): Use equivalent enum value
ISOLATED_MESSAGE instead of 0.
---
gdb/complaints.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/gdb/complaints.c b/gdb/complaints.c
index dbacb2a..3566904 100644
--- a/gdb/complaints.c
+++ b/gdb/complaints.c
@@ -34,11 +34,14 @@ extern void _initialize_complaints (void);
enum complaint_series {
/* Isolated self explanatory message. */
ISOLATED_MESSAGE,
+
/* First message of a series, includes an explanation. */
FIRST_MESSAGE,
+
/* First message of a series, but does not need to include any sort
of explanation. */
SHORT_FIRST_MESSAGE,
+
/* Subsequent message of a series that needs no explanation (the
user already knows we have a problem so we can just state our
piece). */
@@ -75,7 +78,7 @@ struct complaints
must start off with explanation. case 2: Subsequent message of a
series that needs no explanation (the user already knows we have
a problem so we can just state our piece). */
- int series;
+ enum complaint_series series;
/* The explanatory messages that should accompany the complaint.
NOTE: cagney/2002-08-14: In a desperate attempt at being vaguely
@@ -99,7 +102,7 @@ static struct explanation symfile_explanations[] = {
static struct complaints symfile_complaint_book = {
&complaint_sentinel,
- 0,
+ ISOLATED_MESSAGE,
symfile_explanations
};
struct complaints *symfile_complaints = &symfile_complaint_book;
--
2.1.4