This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V4 5/9] New probe type: DTrace USDT probes.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>, gdb-patches at sourceware dot org
- Date: Fri, 7 Aug 2015 08:20:07 -0700
- Subject: Re: [PATCH V4 5/9] New probe type: DTrace USDT probes.
- Authentication-results: sourceware.org; auth=none
- References: <1422874968-382-6-git-send-email-jose dot marchesi at oracle dot com> <87r3tp722i dot fsf at redhat dot com> <20150325191418 dot GA32233 at adacore dot com> <87bnjfraq1 dot fsf at oracle dot com> <20150326175028 dot GA13867 at adacore dot com> <87y4mdjcie dot fsf at oracle dot com> <20150331184727 dot GF13867 at adacore dot com> <878uedey48 dot fsf at oracle dot com> <20150806213103 dot GC14992 at adacore dot com> <87r3ngf4dq dot fsf at redhat dot com>
> Pretty nice investigation, Joel!
>
> This patch makes sense to me and is OK to go in (it just has a small
> typo below).
Thanks! Patch just pushed with the tiny correction you indicated.
> Something I don't like about this goto scheme is that it doesn't contain
> useful information as to why the section has been discarded ("... does
> not contain valid DOF data" is too generic). But I'm just speaking my
> mind here; this has nothing to do with your patch :-).
We could improve it indeed. For a rainy day...
--
Joel