This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V4 5/9] New probe type: DTrace USDT probes.


> Pretty nice investigation, Joel!
> 
> This patch makes sense to me and is OK to go in (it just has a small
> typo below).

Thanks! Patch just pushed with the tiny correction you indicated.

> Something I don't like about this goto scheme is that it doesn't contain
> useful information as to why the section has been discarded ("... does
> not contain valid DOF data" is too generic).  But I'm just speaking my
> mind here; this has nothing to do with your patch :-).

We could improve it indeed. For a rainy day...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]