This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/7] Merge async and sync code paths some more
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 12 Aug 2015 15:48:30 -0400
- Subject: Re: [PATCH 1/7] Merge async and sync code paths some more
- Authentication-results: sourceware.org; auth=none
- References: <1439398917-22761-1-git-send-email-palves at redhat dot com> <1439398917-22761-2-git-send-email-palves at redhat dot com>
On 15-08-12 01:01 PM, Pedro Alves wrote:
> diff --git a/gdb/mi/mi-interp.c b/gdb/mi/mi-interp.c
> index 99ce385..bdd8e21 100644
> --- a/gdb/mi/mi-interp.c
> +++ b/gdb/mi/mi-interp.c
> @@ -309,16 +309,8 @@ mi_execute_command_wrapper (const char *cmd)
> static void
> mi_on_sync_execution_done (void)
> {
> - /* MI generally prints a prompt after a command, indicating it's
> - ready for further input. However, due to an historical wart, if
> - MI async, and a (CLI) synchronous command was issued, then we
> - will print the prompt right after printing "^running", even if we
> - cannot actually accept any input until the target stops. See
> - mi_on_resume. However, if the target is async but MI is sync,
> - then we need to output the MI prompt now, to replicate gdb's
> - behavior when neither the target nor MI are async. (Note this
> - observer is only called by the asynchronous target event handling
> - code.) */
> + /* If we MI is sync, then output the MI prompt now, indicating we're
> + ready for further input. */
"If we MI is sync"