This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/7] Replace "struct continuation" mechanism by something more extensible
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 18 Aug 2015 13:50:22 +0100
- Subject: Re: [PATCH 2/7] Replace "struct continuation" mechanism by something more extensible
- Authentication-results: sourceware.org; auth=none
- References: <1439398917-22761-1-git-send-email-palves at redhat dot com> <1439398917-22761-3-git-send-email-palves at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> (tui_init): Install tui_on_normal_stop as normal_stop
> * observer.
>
Remove *.
> +
> +/* Prepare for a step/next/etc. command. Any target resource
> + allocated here is undone in the FSM's clean_up method. */
> +
> +static void
> +step_command_fsm_prepare (struct step_command_fsm *sm,
> + int skip_subroutines, int single_inst,
> + int count, int thread)
> +{
> + struct thread_info *tp = inferior_thread ();
Nit: get thread_info by THREAD rather than inferior_thread ()?
> +
> +/* Implementation of the 'should_stop' FSM method for the finish
> + commands. Detects whether the thread stepped out of the function
> + successfully, and if so, captures the function's return value and
> + marks the FSM finished. */
> +
> +static int
> +finish_command_fsm_should_stop (struct thread_fsm *self)
> {
> - struct finish_command_continuation_args *a = arg;
> + struct finish_command_fsm *f = (struct finish_command_fsm *) self;
> + struct return_value_info *rv = &f->return_value;
> + struct thread_info *tp = inferior_thread ();
Nit: Get TP from f->thread rather than inferior_thread ()?
--
Yao (éå)