This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/7] New regs_info for aarch32
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 18 Aug 2015 16:21:30 +0100
- Subject: Re: [PATCH 2/7] New regs_info for aarch32
- Authentication-results: sourceware.org; auth=none
- References: <1438355801-25798-1-git-send-email-yao dot qi at linaro dot org> <1438355801-25798-3-git-send-email-yao dot qi at linaro dot org> <55BF7383 dot 5030304 at redhat dot com> <55BF980F dot 5010306 at gmail dot com> <55BFA0AD dot 5000408 at redhat dot com> <86614ve5z5 dot fsf at gmail dot com> <20150811194012 dot GA19956 at adacore dot com>
On 11/08/15 20:40, Joel Brobecker wrote:
This patch is causing a GDBserver build failure on some versions
of GNU/Linux (the version we support is fairly old), but also on
relatively recent versions of Android as well.
The problem is that NT_ARM_VFP is not always defined. I tried
the attached patch, which I was a bit dubious about, but seems
to work ("info float" does not error out, and print a series of zeros),
but I'm not sure whether I'm exercising the code at all. The other
alternative I was thinking of was perhaps to just #ifndef out
the entry in aarch32_regsets that needs NT_ARM_VFP. It might be
cleaner, but I haven't tried it.
If kernel doesn't support NT_ARM_VFP, GDBserver
(linux-low.c:regsets_fetch_inferior_registers) can disable this
regset_info. On the other hand, if kernel is too old to support
PTRACE_GETREGSET, aarch32_regsets won't be used at all.
gdb/gdbserver/ChangeLog:
* linux-aarch32-low.c (NT_ARM_VFP): Define if not already defined.
Patch looks right to me.
--
Yao (éå)