This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Use tui_putc to output newline entered by the user
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: gdb-patches at sourceware dot org
- Cc: Patrick Palka <patrick at parcs dot ath dot cx>
- Date: Fri, 21 Aug 2015 12:19:55 -0400
- Subject: [PATCH] Use tui_putc to output newline entered by the user
- Authentication-results: sourceware.org; auth=none
This is necessary to make sure that start_line is updated after a
command has been entered. Usually, start_line gets updated anyway
because most commands output text, and outputting text is done through
the function tui_puts, which updates start_line. However if a command
does not output text, then tui_puts will not get called and start_line
will not get updated in time for the next prompt to be displayed.
One can observe this bug by executing the command "delete" within TUI.
After executing, the prompt line
(gdb) delete
gets overwritten by the next prompt. With this patch, the prompt line
gets preserved.
[ I extracted this patch out from my series that fixes PR tui/14584
because it's mostly an independent bugfix. ]
gdb/ChangeLog:
* tui/tui-io.c (tui_getc): Use tui_putc instead of waddch to
emit the newline.
---
gdb/tui/tui-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c
index f0ff5c0..bca1f58 100644
--- a/gdb/tui/tui-io.c
+++ b/gdb/tui/tui-io.c
@@ -606,7 +606,7 @@ tui_getc (FILE *fp)
py += px / TUI_CMD_WIN->generic.width;
px %= TUI_CMD_WIN->generic.width;
wmove (w, py, px);
- waddch (w, ch);
+ tui_putc ('\n');
}
}
--
2.5.0.417.g69c5dbd.dirty