Re: [PATCH v12 06/32] Validate symbol file using build-id

[Eli Zaretskii <eliz at gnu dot org>]

> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Date: Fri, 21 Aug 2015 23:20:57 +0200
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -35,6 +35,20 @@ show debug bfd-cache
>    The "/m" option is now considered deprecated: its "source-centric"
>    output hasn't proved useful in practice.
>  
> +* New options
> +
> +set validate-build-id (on|off)
> +show validate-build-id
> +  Inferior shared library and symbol file may contain unique build-id.
> +  If both build-ids are present but they do not match then this setting
> +  enables (off) or disables (on) loading of such symbol file.
> +
> +* New features in the GDB remote stub, GDBserver
> +
> +  ** library-list-svr4 contains also optional attribute 'build-id' for
> +     each library.  GDB does not load library with build-id that
> +     does not match such attribute.
> +
>  *** Changes in GDB 7.10

This is OK.

> +static void
> +show_validate_build_id (struct ui_file *file, int from_tty,
> +			struct cmd_list_element *c, const char *value)
> +{
> +  fprintf_filtered (file, _("Validation a build-id matches to load a shared "
> +			    "library is %s.\n"),

I think this message is not a valid English sentence.  I suggest this
instead:

  Validation of build-id match when loading a shared library is %s.\n

> +void
> +_initialize_build_id (void)
> +{
> +  add_setshow_boolean_cmd ("validate-build-id", class_support,
> +			   &validate_build_id, _("\
> +Set validation a build-id matches to load a shared library."), _("\

Likewise here, I suggest this alternative:

 Set whether to validate build-id match when loading a shared library.

> +SHow validation a build-id matches to load a shared library."), _("\
   ^^
Capitalization.  Also, if you accept my suggestion above, change this
text accordingly.

> +Inferior shared library and symbol file may contain unique build-id.\n\
> +If both build-ids are present but they do not match then this setting\n\
                                ^                     ^
Commas missing where indicated.

Thanks.