This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 00/19] New completer API
- From: Doug Evans <xdje42 at gmail dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Sat, 22 Aug 2015 15:24:22 -0700
- Subject: Re: [PATCH v3 00/19] New completer API
- Authentication-results: sourceware.org; auth=none
- References: <20150806191404 dot 32159 dot 50755 dot stgit at valrhona dot uglyboxes dot com> <20150807225655 dot GA2986 at embecosm dot com> <55C54778 dot 2030004 at redhat dot com> <20150808064442 dot GB2986 at embecosm dot com> <55C62D6D dot 1000903 at redhat dot com>
Keith Seitz <keiths@redhat.com> writes:
> On 08/07/2015 11:44 PM, Andrew Burgess wrote:
>>> I don't like boolean return values in this case. Forget knowing what
>>> happens under the covers (or now that you've read the proposed API).
>>> Just by reading "bool add_completion (struct completer_data *, const
>>> char *);" can you tell what the boolean return value means?
>>
>> No. But you could rename to
>> add_completion_then_should_more_completions_be_added (he jokes)
>> (though maybe add_completion_and_continue would work?). But
>> I would have just assumed a good comment was enough.
>
> I'll have to try and sneak something like that past Doug on some other
> series. :-)
Heh. :-)
fyi, reviewing this patchset is one of my projects for this weekend.