This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Prevent GCC from folding inline test functions
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, gdb-patches at sourceware dot org
- Date: Mon, 24 Aug 2015 17:07:09 +0100
- Subject: Re: [PATCH] Prevent GCC from folding inline test functions
- Authentication-results: sourceware.org; auth=none
- References: <1440162341-26343-1-git-send-email-lgustavo at codesourcery dot com> <55D74BCE dot 5020206 at redhat dot com> <55DB3CE1 dot 7020402 at codesourcery dot com> <55DB3E15 dot 2080402 at redhat dot com> <55DB3F45 dot 4030602 at codesourcery dot com>
On 08/24/2015 04:59 PM, Luis Machado wrote:
> On 08/24/2015 12:53 PM, Pedro Alves wrote:
>> On 08/24/2015 04:48 PM, Luis Machado wrote:
>>> --- a/gdb/testsuite/gdb.opt/inline-markers.c
>>> +++ b/gdb/testsuite/gdb.opt/inline-markers.c
>>> @@ -13,7 +13,7 @@
>>> You should have received a copy of the GNU General Public License
>>> along with this program. If not, see <http://www.gnu.org/licenses/>. */
>>>
>>> -extern int x, y;
>>> +extern int x, y, z;
>>
>> z here should match the definition (should be volatile here too).
>>
>> Thanks,
>> Pedro Alves
>>
>
> Fixed with 91dddb86299bba404599551e9e2633b3c0e5c830.
>
Thanks. Though,
-extern int x, y, z;
+extern int x, y;
+extern volatile z;
I think this will cause trouble with newer gcc that default
to gnu c11. Since C99 that a missing type specifier is no
longer implicitly assumed to be int. Thus that should really be:
extern volatile int z;
Thanks,
Pedro Alves