This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFC] Casting NULL pointer


There are a small (~26) number of places where the NULL pointer is
cast list this:

    char *wname = (char *) NULL;

This compares to a huge number of places (~726) where we don't use a
cast, so:

    const char *name = NULL;

I've never thought that the cast was either necessary or a
particularly good idea, it feels like unneeded clutter.

I only ask because I was about to push an obvious change that made a
minor edit to a line containing one of the above casts.  I was tempted
to remove the cast, in this case, as a clean up; however, I'm looking
for confirmation that such a change would be viewed as clean up, and
not an unnecessary change.

As a  follow on, given the small number, I'm happy to submit a
patch(es) to remove all of these casts, if its felt that would be a
reasonable clean up.

Thanks,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]