This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Catching errors on probes-based dynamic linker interface
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 02 Sep 2015 00:21:56 -0400
- Subject: Re: [PATCH 2/2] Catching errors on probes-based dynamic linker interface
- Authentication-results: sourceware.org; auth=none
- References: <1440200253-28603-1-git-send-email-sergiodj at redhat dot com> <1440200253-28603-3-git-send-email-sergiodj at redhat dot com> <20150824084255 dot GA16508 at blade dot nx> <87r3msd5xr dot fsf at redhat dot com> <20150825124748 dot GA6948 at blade dot nx> <87wpwjgrmt dot fsf at redhat dot com> <87lhcq7raj dot fsf at redhat dot com> <20150901092449 dot GA6172 at blade dot nx> <87h9ne6r8j dot fsf at redhat dot com> <8737yx78u5 dot fsf at redhat dot com>
On Wednesday, September 02 2015, I wrote:
> On Tuesday, September 01 2015, I wrote:
>
>>> I am ok with doing this:
>>>
>>> TRY
>>> {
>>> probe_argc = get_probe_argument_count (pa->probe, frame);
>>> }
>>> CATCH (ex, RETURN_MASK_ERROR)
>>> {
>>> exception_print (gdb_stderr, ex);
>>> probe_argc = 0;
>>> }
>>> END_CATCH
>>>
>>> If you put a big fat comment above the following block, e.g.:
>>>
>>> /* Note that failure of get_probe_argument_count will
>>> set probe_argc == 0. This must result in returning
>>> action = PROBES_INTERFACE_FAILED. */
>>> if (probe_argc == 2)
>>> action = FULL_RELOAD;
>>> else if (probe_argc < 2)
>>> action = PROBES_INTERFACE_FAILED;
>>
>> Great, that works for me as well. I will update the patch here to
>> address this.
>
> I took the liberty to modify and expand the comment; I hope you still
> find it OK. Here's what I pushed.
Pushed.
https://sourceware.org/ml/gdb-cvs/2015-09/msg00002.html
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/