This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V2] PR varobj/18564 regression in showing __thread so extern variable


On 09/03/2015 11:03 PM, Philippe Waroquiers wrote:
> On Thu, 2015-09-03 at 10:37 +0100, Yao Qi wrote:
>> We don't have to get printf involved in the test, because some targets
>> may don't have printf at all.
> Ok, effectively, without printf, the test will then run on these
> targets.
> 
> Find below the new version of the patch.
> All your comments should be handled.
> 
> The fix itself still need to be reviewed.
> 
> Thanks for your review
> 
> Any comment on the fix ? Ok to commit ?

This is OK.  Thanks for fixing this.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]