This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/8] [testsuite][AArch64] Enable fast tracepoint tests


Pierre Langlois <pierre.langlois@arm.com> writes:

> gdb/testsuite/ChangeLog:
>
> 	* gdb.trace/change-loc.h (func4): Add a nop instruction for
> 	__aarch64__.

We write ChangeLog for that in this way,

	* gdb.trace/change-loc.h (func4) [__aarch64__]: Add a nop
        instruction.

> 	* gdb.trace/pendshr1.c (pendfunc): Likewise.
> 	* gdb.trace/pendshr2.c (pendfunc2): Likewise.
> 	* gdb.trace/range-stepping.c: Likewise.
> 	* gdb.trace/trace-break.c: Likewise.
> 	* gdb.trace/trace-mt.c (thread_function): Likewise.
> 	* gdb.trace/ftrace.c (marker): Likewise.
> 	* gdb.trace/ftrace-condition.c (marker): Likewise.

The file name should be trace-condition.c.

> 	* gdb.trace/ftrace.exp: Enable ftrace test if is_aarch64_target.
> 	* gdb.trace/ftrace-condition.exp: Set pcreg to "\$pc" if
> 	is_aarch64_target.

Likewise.

Otherwise, patch is OK.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]