This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/8] [GDBserver][AArch64] Add support for fast tracepoints
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pierre Langlois <pierre dot langlois at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 15 Sep 2015 14:00:55 +0100
- Subject: Re: [PATCH 4/8] [GDBserver][AArch64] Add support for fast tracepoints
- Authentication-results: sourceware.org; auth=none
- References: <1442230282-20751-1-git-send-email-pierre dot langlois at arm dot com> <1442230282-20751-5-git-send-email-pierre dot langlois at arm dot com>
Pierre Langlois <pierre.langlois@arm.com> writes:
> /* List of registers that we are currently using, we can add more here as
> + we need to use them. */
> +
> +/* General purpose scratch registers (64 bit). */
> +static struct aarch64_register x0 = { 0, 1 };
> +static struct aarch64_register x1 = { 1, 1 };
> +static struct aarch64_register x2 = { 2, 1 };
> +static struct aarch64_register x3 = { 3, 1 };
> +static struct aarch64_register x4 = { 4, 1 };
> +
> +/* General purpose scratch registers (32 bit). */
> +static struct aarch64_register w2 = { 2, 0 };
> +
> +/* Intra-procedure scratch registers. */
> +static struct aarch64_register ip0 = { 16, 1 };
> +
> +/* Special purpose registers. */
> +static struct aarch64_register sp = { 31, 1 };
> +static struct aarch64_register xzr = { 31, 1 };
Add "const"? like "static const struct aarch64_register xzr".
I go through it quickly, and it looks good to me.
--
Yao (éå)