This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, testsuite] require readline for gdb.linespec/explicit.exp tab-completion tests


Keith Seitz <keiths@redhat.com> writes:
> On 09/17/2015 12:28 AM, Sandra Loosemore wrote:
>> Tab-completion tests require readline support.  The ones in
>> gdb.base/completion.exp are already conditional, but the recently-added
>> gdb.linespec/explicit.exp tests are not.  This patch fixes that, and
>> also an obvious typo ("faill" -> "fail").  The patch is kind of long
>> because I had to insert an "if" block and reindent, but there's nothing
>> else going on here.  OK to commit?
>
> I'm not a maintainer, but I wouldn't hesitate to commit this as obvious.
> Thank you for catching (and fixing) that.

Agreed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]