This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [Ada] Fix handling of array renamings
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre-Marie de Rodat <derodat at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 22 Sep 2015 11:00:25 -0400
- Subject: Re: [PATCH] [Ada] Fix handling of array renamings
- Authentication-results: sourceware.org; auth=none
- References: <1441178473-18654-1-git-send-email-derodat at adacore dot com>
> gdb/ChangeLog:
>
> * ada-lang.c (ada_evaluate_subexp) <OP_FUNCALL>: When the input
> value is a reference, actually dereference it in order to get
> the underlying value.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.ada/array_ptr_renaming.exp: New testcase.
> * gdb.ada/array_ptr_renaming/foo.adb: New file.
> * gdb.ada/array_ptr_renaming/pack.ads: New file.
OK with one tiny little suggestion.
> +gdb_test "print ntp" " = \\(access pack\\.table_type\\) 0x.*"
^^^
Suggest using $hex.* instead of 0x.*
Thanks! And sorry for the late review...
--
Joel