This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, FT32] Replace hard-coded instruction patterns with macros
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: James Bowman <james dot bowman at ftdichip dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 29 Sep 2015 13:54:31 +0100
- Subject: Re: [PATCH, FT32] Replace hard-coded instruction patterns with macros
- Authentication-results: sourceware.org; auth=none
- References: <CA9BBF0458F83C4F9051448B941B57D11961DBC8 at glaexch3>
James Bowman <james.bowman@ftdichip.com> writes:
> 2015-09-28 James Bowman <james.bowman@ftdichip.com>
>
> * ft32-tdep.c: #include "opcode/ft32.h"
> Delete local macro definitions
We should mention the deleted macros here.
> (ft32_analyze_prologue): Use FT32_* macros
It is a sentence, so should be ended with ".".
Otherwise, patch looks good to me.
--
Yao (éå)