This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] infcmd.c: Don't attempt to record a NULL value after a finish command
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 30 Sep 2015 06:01:59 -0700
- Subject: Re: [PATCH] infcmd.c: Don't attempt to record a NULL value after a finish command
- Authentication-results: sourceware.org; auth=none
- References: <20150929214350 dot 44b076c7 at pinnacle dot lan> <560BB90D dot 70905 at redhat dot com> <20150930051736 dot 457e072c at pinnacle dot lan> <560BD3CE dot 1040107 at redhat dot com>
On Wed, 30 Sep 2015 13:21:34 +0100
Pedro Alves <palves@redhat.com> wrote:
> >> I assume that it's record_latest_value that crashes? Isn't the right
> >> fix instead:
> >>
> >> rv->value = get_return_value (func, rv->type);
> >> - rv->value_history_index = record_latest_value (rv->value);
> >> + if (rv->value != NULL)
> >> + rv->value_history_index = record_latest_value (rv->value);
> >>
> >
> > You're right. (I honestly don't know what I was thinking.)
> >
> > Please commit your patch instead.
>
> I don't have a patch -- I wrote that hunk by hand
> in the mail client. :-) Please fix up yours and push it.
Oh, okay.
It's pushed.
Kevin