This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame'.


On 09/11/2015 07:49 PM, Andrew Burgess wrote:

> --- a/gdb/stack.c
> +++ b/gdb/stack.c
> @@ -100,6 +100,9 @@ static void set_last_displayed_sal (int valid,
>  				    struct symtab *symtab,
>  				    int line);
>  
> +static struct frame_info * find_frame_for_function (char *);
> +static struct frame_info * find_frame_for_address (CORE_ADDR);

No space after first *.  Also, can that be "const char *" ?

But most importantly - is there a reason this is implemented
the way it is (manually handling completion, parsing, etc.) instead of
creating sub-commands for "frame", etc., like done e.g., for "thread",
thread apply", "thread apply all", etc. ?

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]