This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] gdb: Improve syscall entry/return tracking on Linux
- From: Pedro Alves <palves at redhat dot com>
- To: Josh Stone <jistone at redhat dot com>, gdb-patches at sourceware dot org
- Cc: sergiodj at redhat dot com
- Date: Sat, 10 Oct 2015 15:51:56 +0100
- Subject: Re: [PATCH v2] gdb: Improve syscall entry/return tracking on Linux
- Authentication-results: sourceware.org; auth=none
- References: <5617FFF8 dot 50905 at redhat dot com> <1444434776-4016-1-git-send-email-jistone at redhat dot com>
On 10/10/2015 12:52 AM, Josh Stone wrote:
> 2015-10-09 Josh Stone <jistone@redhat.com>
>
> * gdb.base/catch-syscall.c (unknown_syscall): New variable.
> (main): Trigger a vfork and an unknown syscall.
* gdb.base/catch-syscall.c: Include <sched.h>.
(unknown_syscall): New variable.
(main): Trigger a vfork and an unknown syscall.
...
> int
> @@ -47,6 +49,13 @@ main (void)
> write (fd[1], buf1, sizeof (buf1));
> read (fd[0], buf2, sizeof (buf2));
>
> + /* Test vfork-event interactions. Child exits immediately. */
> + if (vfork () == 0)
> + _exit (0);
Please mention that we avoid fork so the test works on no-mmu
configurations.
> # This procedure checks if there was a call to a syscall.
> -proc check_call_to_syscall { syscall } {
> +proc check_call_to_syscall { syscall { pattern "" } } {
Please extend the intro comment to mention what PATTERN is for.
OK with these changes.
Thanks,
Pedro Alves