This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH c++ 3/5] mep: Add cast for int to enum conversion
- From: Simon Marchi <thundersim at gmail dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 12 Oct 2015 12:43:46 -0400
- Subject: Re: [PATCH c++ 3/5] mep: Add cast for int to enum conversion
- Authentication-results: sourceware.org; auth=none
- References: <1444538238-7468-1-git-send-email-simon dot marchi at polymtl dot ca> <1444538238-7468-3-git-send-email-simon dot marchi at polymtl dot ca> <86io6c5q9h dot fsf at gmail dot com>
On 12/10/15 06:34 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Hi Simon,
> Patch is OK, one nit below,
>
>> @@ -2396,7 +2396,10 @@ mep_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>> /* The way to get the me_module code depends on the object file
>> format. At the moment, we only know how to handle ELF. */
>> if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour)
>> - me_module = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK;
>> + {
>> + int flag = elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK;
>
> A blank line is needed here.
>
>> + me_module = (CONFIG_ATTR) flag;
>> + }
>> else
>> me_module = CONFIG_NONE;
>> }
>
Thanks, pushed with the newline.