This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH c++ 1/5] lm32: Add (const gdb_byte *) cast
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Tue, 13 Oct 2015 18:32:18 +0100
- Subject: Re: [PATCH c++ 1/5] lm32: Add (const gdb_byte *) cast
- Authentication-results: sourceware.org; auth=none
- References: <1444538238-7468-1-git-send-email-simon dot marchi at polymtl dot ca> <561B952D dot 8060909 at redhat dot com> <561D3BEB dot 9090409 at ericsson dot com>
On 10/13/2015 06:14 PM, Simon Marchi wrote:
> On 15-10-12 07:10 AM, Pedro Alves wrote:
>> This reveals that the code has a host-dependency. It is assuming the
>> byte order of the target is the same as host's.
>>
>> Please replace this with a call to write_memory_unsigned_integer.
>>
>> Looks like this port hasn't been touched ever since it was
>> originally contributed. Jon, is there still interest in this port?
>>
>> Thanks,
>> Pedro Alves
>
> Ah, thanks for the tip. It would look like this then:
Looks good.
Thanks,
Pedro Alves