This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 2/7] Add breakpoint_from_kind target_ops for software breakpoints in GDBServer.




On 10/15/2015 05:09 AM, Yao Qi wrote:
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

+static const unsigned char*
+linux_breakpoint_from_kind (int *kind)
+{
+  if (*the_low_target.breakpoint_from_kind != NULL)
+    return (*the_low_target.breakpoint_from_kind) (kind);
+  else
+    return NULL;
+}

What does returned NULL mean?  We need to assert
the_low_target.breakpoint_from_kind isn't NULL, as a sanity check?


Yes that's a left over from previous implementations, it should assert now as breakpoint_from_kind is mandatory.

I'll fix it.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]