This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 7/7] Support software breakpoints for ARM linux in GDBServer.
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Fri, 16 Oct 2015 12:52:23 +0100
- Subject: Re: [PATCH v2 7/7] Support software breakpoints for ARM linux in GDBServer.
- Authentication-results: sourceware.org; auth=none
- References: <1444063455-31558-1-git-send-email-antoine dot tremblay at ericsson dot com> <1444063455-31558-8-git-send-email-antoine dot tremblay at ericsson dot com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> +/* Get the breakpoint from the remote kind
> + 2 is thumb-16
> + 3 is thumb2-32
> + 4 is arm
> +*/
Need comment /* Implementation of .... */
> +static const unsigned char *
> +arm_breakpoint_from_kind (int *kind)
> +{
> + switch (*kind) {
Wrong format. "{" should be put in the next line.
> + case 2:
> + return (unsigned char *) &thumb_breakpoint;
> + case 3:
> + *kind = 4;
> + return (unsigned char *) &thumb2_breakpoint;
> + case 4:
> + return (unsigned char *) &arm_breakpoint;
> + default:
> + return NULL;
> + }
> + return NULL;
> +}
Otherwise, patch is good to me.
--
Yao (éå)