This is the mail archive of the
mailing list for the GDB project.
Re: gdb/linux-record fixes
- From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
- To: Pedro Alves <palves at redhat dot com>, Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 22 Oct 2015 15:34:14 +0200
- Subject: Re: gdb/linux-record fixes
- Authentication-results: sourceware.org; auth=none
- References: <1445118081-10908-1-git-send-email-koriakin at 0x04 dot net> <56250E2D dot 7020009 at redhat dot com> <562525C1 dot 7000205 at 0x04 dot net> <5626206E dot 1000405 at redhat dot com> <5626226D dot 3010203 at 0x04 dot net>
On 20/10/15 13:15, Marcin KoÅcielnicki wrote:
On 20/10/15 13:07, Pedro Alves wrote:
On 10/19/2015 06:17 PM, Marcin KoÅcielnicki wrote:
Yeah, they're not covered by the testsuite. Actually, there seem to be
only two tests in gdb.reverse suite that even touch syscalls:
sigall-reverse (signal, sigprocmask, exit_group) and watch-reverse
(read, write). No wonder that syscall handling is buggy...
Stepping forward and backward over pipe/time/waitpid would indeed do the
trick for patch #6.
Can I convince you to add that to the patch (and likewise to others that
might not be overly hard)?
I'll do that, if I'm not overcome by dejaGNU... I have no idea how that
stuff works at the moment.
BTW, you'll also need to include ChangeLog entries. Please check here:
OK, will do.
Here comes v2:
- ChangeLog entries added
- I've split the last patch in two (termios and x32)
- test cases are included that exercise #2 (getresuid), #5 (readmsg), #6
(time, waitpid, pipe), #8 (fstatat), #12 (readv); testing the rest would
be rather contrived
Unfortunately, my waitpid test appears to trigger another bug - going
over a fork with a breakpoint active while recording causes an error:
record-full.c:1716: internal-error: record_full_remove_breakpoint:
removing unknown breakpoint
I'll try to debug this problem this weekend. Should I remove the
waitpid test from this patchset for now, or mark it as an expected-fail