This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer.
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: <gdb-patches at sourceware dot org>, <palves at redhat dot com>
- Date: Thu, 22 Oct 2015 09:55:44 -0400
- Subject: Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer.
- Authentication-results: sourceware.org; auth=none
- References: <20151022134952 dot 1AF5AF738 at oc7340732750 dot ibm dot com>
On 10/22/2015 09:49 AM, Ulrich Weigand wrote:
Antoine Tremblay wrote:
gdb/gdbserver/ChangeLog:
* mem-break.c : Remove breakpoint_data/breakpoint_len global variables.
(set_breakpoint_data): Remove.
This breaks building gdbserver for spu-elf:
spu-low.o: In function `initialize_low':
gdb/gdbserver/spu-low.c:684: undefined reference to `set_breakpoint_data'
and most likely other non-Linux gdbserver targets that still refer to
set_breakpoint_data:
gdb/gdbserver/nto-low.c: set_breakpoint_data (the_low_target.breakpoint,
gdb/gdbserver/win32-low.c: set_breakpoint_data (the_low_target.breakpoint,
What needs to be done to fix those?
Right, I need to implement the breakpoint_kind_from_pc and
breakpoint_from_kind in non-linux targets.
I'll send a patch soon.
B.t.w. if set_breakpoint_data is really gone, its prototype should be
removed from mem-break.h as well.
Indeed will patch this too.