This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 5/9] gdb: Fix bug with dbx style func command.
- From: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- To: "'Pedro Alves'" <palves at redhat dot com>, "Andrew Burgess" <andrew dot burgess at embecosm dot com>, <gdb-patches at sourceware dot org>
- Date: Mon, 26 Oct 2015 18:38:17 +0800
- Subject: RE: [PATCH 5/9] gdb: Fix bug with dbx style func command.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1441996064 dot git dot andrew dot burgess at embecosm dot com> <8629fd6198d107d87d4db9b3eec45774bfaae2b6 dot 1441996064 dot git dot andrew dot burgess at embecosm dot com> <560BE7EE dot 2090401 at redhat dot com>
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Wednesday, September 30, 2015 9:47 PM
>
> On 09/11/2015 07:49 PM, Andrew Burgess wrote:
> > The func command, available when starting gdb in dbx mode, is
> supposed
> > to take a function name and locate the frame for that function in the
> > stack. This has been broken for a while due to an invalid check of the
> > arguments within the worker function. Fixed in this commit.
>
> I wonder whether anyone uses / cares about the dbx mode...
>
> >
> > gdb/ChangeLog:
> >
> > * stack.c (func_command): Return early when there is no ARG
> > string.
> >
> > gdb/testsuite/ChangeLog:
> >
> > * gdb.base/dbx.exp (test_func): Remove xfails, update
> expected
> > results.
>
> OK.
Actually dbx style func still fails on ARM so this changes shows up as a regression (XFAIL- > FAIL). See [1] for a bit more details.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=19127
Best regards,
Thomas