This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/9] gdb: Fix bug with dbx style func command.
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: Thomas Preud'homme <thomas dot preudhomme at arm dot com>
- Cc: 'Pedro Alves' <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Mon, 26 Oct 2015 13:40:07 +0000
- Subject: Re: [PATCH 5/9] gdb: Fix bug with dbx style func command.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1441996064 dot git dot andrew dot burgess at embecosm dot com> <8629fd6198d107d87d4db9b3eec45774bfaae2b6 dot 1441996064 dot git dot andrew dot burgess at embecosm dot com> <560BE7EE dot 2090401 at redhat dot com> <003301d10fda$6e7f2ad0$4b7d8070$ at arm dot com>
* Thomas Preud'homme <thomas.preudhomme@arm.com> [2015-10-26 18:38:17 +0800]:
> > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> > owner@sourceware.org] On Behalf Of Pedro Alves
> > Sent: Wednesday, September 30, 2015 9:47 PM
> >
> > On 09/11/2015 07:49 PM, Andrew Burgess wrote:
> > > The func command, available when starting gdb in dbx mode, is
> > supposed
> > > to take a function name and locate the frame for that function in the
> > > stack. This has been broken for a while due to an invalid check of the
> > > arguments within the worker function. Fixed in this commit.
> >
> > I wonder whether anyone uses / cares about the dbx mode...
> >
> > >
> > > gdb/ChangeLog:
> > >
> > > * stack.c (func_command): Return early when there is no ARG
> > > string.
> > >
> > > gdb/testsuite/ChangeLog:
> > >
> > > * gdb.base/dbx.exp (test_func): Remove xfails, update
> > expected
> > > results.
> >
> > OK.
>
> Actually dbx style func still fails on ARM so this changes shows up
> as a regression (XFAIL- > FAIL). See [1] for a bit more details.
The failure you're seeing on ARM, where gdb says "Target is
executing." seems pretty strange, and certainly isn't the failure that
I would have expected before, this looks like a different issue, which
is probably worth some investigation. I'm guessing here, but I doubt
that the original XFAIL I removed was intended to mask this specific
failure.
It would probably help to diagnose this issue if you could attach a
gdb.log for a test run of dbx.exp.
Thanks,
Andrew