This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH c++ 01/12] Introduce ax_raw_byte and use it
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 27 Oct 2015 09:36:51 -0400
- Subject: Re: [PATCH c++ 01/12] Introduce ax_raw_byte and use it
- Authentication-results: sourceware.org; auth=none
- References: <1445831204-16588-1-git-send-email-simon dot marchi at polymtl dot ca> <562F6B02 dot 60605 at redhat dot com>
On 27/10/15 08:16 AM, Pedro Alves wrote:
> On 10/26/2015 03:46 AM, Simon Marchi wrote:
>> This patch was taken directly from Pedro's branch.
>>
>
> Thanks.
>
>> ax_simple is used to append an agent expression operator to an agent
>> expression string. Therefore, it takes an enum agent_op as input.
>> There is an instance where it's called to append a raw byte, unrelated
>> to the enum. It makes the build fail in C++ mode.
>>
>> This patch introduces ax_raw_byte for that purpose and uses it.
>>
>> gdb/ChangeLog:
>>
>> * ax.h (ax_raw_byte): New declaration.
>> * ax-general.c (ax_raw_byte): New function.
>> (ax_simple): Use ax_raw_byte.
>> * ax-gdb.c (gen_printf): Likewise.
>
> OK.
>
> Thanks,
> Pedro Alves
>
Pushed thanks.