This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v1] ABI changes for Intel(R) MPX.
- From: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: "palves at redhat dot com" <palves at redhat dot com>, "brobecker at adacore dot com" <brobecker at adacore dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 27 Oct 2015 14:59:46 +0000
- Subject: RE: [PATCH v1] ABI changes for Intel(R) MPX.
- Authentication-results: sourceware.org; auth=none
- References: <1445864086-4831-1-git-send-email-walfred dot tedeschi at intel dot com> <1445864086-4831-6-git-send-email-walfred dot tedeschi at intel dot com> <83ziz5bodv dot fsf at gnu dot org>
Eli,
Thanks a lot for your review!
I will use your version and remove also the (R).
Thanks again,
-Fred
-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Eli Zaretskii
Sent: Monday, October 26, 2015 5:12 PM
To: Tedeschi, Walfred
Cc: palves@redhat.com; brobecker@adacore.com; gdb-patches@sourceware.org
Subject: Re: [PATCH v1] ABI changes for Intel(R) MPX.
> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Cc: gdb-patches@sourceware.org, Walfred Tedeschi
> <walfred.tedeschi@intel.com>
> Date: Mon, 26 Oct 2015 13:54:46 +0100
>
> doc:
> gdb.texinfo: (Intel(R) Memory Protection Extensions): Add
> documentation on performing program function calls.
Is it possible to lose the "(R)" part here? It gets in the way of Emacs syntax highlighting of ChangeLog entries.
> +While calling functions of an MPX enabled program boundary registers
> +have to be initialized before performing the call. Intended to avoid
> +unexpected side effects, as receiving a bound violation signal while
> +performing the operation. Nevertheless is possible to change the
> +boundary values if desired in placing a breakpoint at the end of the
> +prologue and setting bound registers as wished.
> +After the call is performed bound register might be keept or not for
> +further investigations. The behaviour of initializing bounds on
> +returning from a program function calls can be controlled and
> +vizualized via the commands @table @code @kindex set
> +mpx-bnd-init-on-return When set to 1 bound registers will be
> +initialized when returning from a calling a program function @kindex
> +show mpx-bnd-init-on-return Show the state of mpx-bnd-init-on-return.
> +@end table
There are a few English and Texinfo issues here, so I suggest the following minor rewording (please make sure I didn't change the meaning of what you intended to say):
While calling functions of an MPX enabled program, boundary registers have
to be initialized before performing the call, to avoid unexpected side
effects, such as a bound violation exception, while performing the
operation. Nevertheless, is possible to change the boundary values, if
desired, by placing a breakpoint at the end of the prologue and setting
bound registers as wished in the commands of that breakpoint.
After the call is performed, a bound register might or might not be keept for
further investigations. The behaviour of initializing bounds on returning
from a program function calls can be controlled and displayed using the
following commands:
@table @code
@kindex set mpx-bnd-init-on-return
@item set mpx-bnd-init-on-return
When set to 1, bound registers will be initialized when returning from a
calling a program function.
@kindex show mpx-bnd-init-on-return
@item show mpx-bnd-init-on-return
Show the state of @code{mpx-bnd-init-on-return}.
@end table
Thanks.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928