This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [PR symtab/17911] Recognize bad file types
- From: Doug Evans <xdje42 at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 27 Oct 2015 08:47:28 -0700
- Subject: Re: [PATCH] [PR symtab/17911] Recognize bad file types
- Authentication-results: sourceware.org; auth=none
- References: <m34miqm3rq dot fsf at seba dot sebabeach dot org> <560AA051 dot 6060803 at redhat dot com> <m3lhap9ovt dot fsf at sspiff dot org> <562F77F6 dot 60503 at redhat dot com>
On Tue, Oct 27, 2015 at 6:11 AM, Pedro Alves <palves@redhat.com> wrote:
> On 10/26/2015 11:44 PM, Doug Evans wrote:
>> Pedro Alves <palves@redhat.com> writes:
>>> Seems like there are function calls after these that may
>>> clobber errno. I think it'd be safer to do the usual
>>> save_errno = errno; / errno = save_errno; dance.
>>
>> Does what you're saying apply to the current source base?
>> [I think so, just checking.
>> And if so, then let's fix that first.]
>>
>
> Like so.
So you were referring to the existing code.
[One can see this bug easily enough, but it wasn't clear
whether you were saying my bug was introducing
another bug.]
gdb is always more broken than one imagines. :-)
LGTM.